Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a breaking change by removing the bonjour feature from rspack-dev-server. The implementation involves removing the bonjour-service dependency and all associated code, including types, configuration options, and implementation logic. The corresponding tests and test snapshots for the bonjour feature have also been correctly removed. The changes appear to be complete and consistent with the stated goal of removing this feature. A change to the VS Code settings to switch the default formatter to Prettier is also included. No issues were found during the review.
There was a problem hiding this comment.
Pull request overview
This PR removes the bonjour/ZeroConf (mDNS) broadcasting feature from @rspack/dev-server, including its runtime implementation, type surface, tests, and dependency footprint.
Changes:
- Removed the
bonjouroption from dev-server configuration/types and deleted the implementation hooks insrc/server.ts. - Deleted the e2e test suite and snapshots for
bonjour, and removed related port mappings. - Dropped
bonjour-serviceand related type/dependency entries frompackage.jsonandpnpm-lock.yaml.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/helpers/ports-map.js | Removes bonjour and cli-bonjour port allocations used by the deleted tests. |
| tests/e2e/bonjour.test.js | Deletes the e2e coverage for the bonjour option. |
| tests/e2e/snapshots/bonjour.test.js.snap.webpack5 | Removes snapshots tied to the deleted bonjour tests. |
| src/types.ts | Removes exported Bonjour/BonjourOptions types sourced from bonjour-service. |
| src/server.ts | Removes the bonjour configuration option and all runtime start/stop + logging behavior. |
| src/config.ts | Removes bonjour from the resolved dev server typing. |
| pnpm-lock.yaml | Removes bonjour-service and transitive packages from the lockfile. |
| package.json | Removes bonjour-service and @types/bonjour dependencies. |
| .vscode/settings.json | Changes VS Code default formatter settings (not directly related to bonjour removal). |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove the
bonjouroption from rspack-dev-server.bonjouris rarely used in modern setups and adds unnecessary dependencies. Major modern dev tools such as Rsbuild, Vite, and Next.js do not provide this feature.